The process of classifying material is uncontroversial because in general parlance, we assume that material is specific intelligence of people, place, and times.
The extension of that definition to include classified courts with classified rulings used as the legal basis for programs like this... is not the generally accepted one.
I don't know why you'd assume it's specific intel of that. Classified info is literally anything that would be a risk to national security if released in an uncontrolled fashion. The 3 different tiers of U.S. classification are literally just the 3 different levels of damage that would accrue to U.S. national security, nothing more.
So in the case of programs like this, if the hypothetical terr'ists know about it, that lets them know services to avoid, or communications methods to avoid, etc., which might enable them to form networks that the NSA would otherwise have been able to unravel before their next terrorist attack.
So it's not completely inconceivable that there's a valid reason to apply classification standards.
I happen to think that the importance of transparency is such that we need to at least have that public discussion about what types of records NSA would be storing, searching, and examining.
But at the same time the NSA has literally been doing this for decades, Congress has had classified hearings for longer, and the Republic has refused to fall. I don't know for sure about classified courts, but neither would that surprise me too much.
There is no Salafi army capable of achieving military victory against the United States. The existential threat is zero.
Therefore, I see no reason why our sacred liberties should be secretly sacrificed as "tactics" in an eternal, global war.
Better to declare global perpetual war against pools, bathtubs, or uncooked food. It would be cheaper and save more lives. Oh, and, preserve the sacrifice of those who died fighting for our freedom.
Or, is a life lost to a one who has claimed jihad worth more than one from uncooked food?
It may be that Bush was right, that terrorists wish us to abandon our liberties. So, too do the disciples of Leo Strauss who want to elevate to warriors the ideology of people who are merely sad, pathetic men no different from the killers of random school shootings, and deserve no more.
I can't speak for you (I'm immersed in a bunch of "privilege" already), but the actual concrete effect on my civil liberties, even since 9/11, has been exactly zero.
Remember we oppose tools such as these based on what the government might be able to do with them to abuse their citizens, just like we field militaries based on what other nations might be able to do.
So far your Salafi army example applies in reverse as well: The U.S. government hasn't been running around actually repressing the citizenry. Certainly we should take measures to ensure they can't, but as long as we're worrying about what people might do then I don't see why it's shameful to worry about what Islamists might do as well.
The extension of that definition to include classified courts with classified rulings used as the legal basis for programs like this... is not the generally accepted one.