Hacker News new | past | comments | ask | show | jobs | submit login

I only looked at the linked file, so I'm not going to speak to the rest of the code and don't really have a good grasp of the architecture here.

This seems mostly ok. The only thing that (imo) wouldn't pass code review is that big honking loop at https://github.com/achristmascarl/rainfrog/blob/main/src/app.... That thing needs to be refactored down to be readable, with individual logic chunks being put into their own functions and tidied up a bit.

That's not really Rust-specific, obviously, but all the `match` and `if let` and whatever other Rust stuff looks fine, so it's what I've got.






Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: