This seems to come very close to recognising that if someone without permissions pushes something to a repository, it should be convered into a PR.
> If you've ever used the email workflow I don't think I need to explain why it sucks.
I prefer it FWIW. After setting up your Email, it is much easier and faster to send a mail than go through a PR-process. On the reciving end you can respond inline to the patch, in the compfort of your email client, without having to use a browser.
My feeling is that people who don't like this, don't have a good mail setup (which is understandable given some hosts), making Email much more painful to use in general.
If you review PRs as whole, you don't need to use the web interface. I think it only gets harder when you want to do inline comments. At least that's what the docs for github cli suggest. https://cli.github.com/manual/gh_pr_review
It does seem like it would be hard to support inline comments properly outside of an email quoting context without editor integration.
> If you've ever used the email workflow I don't think I need to explain why it sucks.
I prefer it FWIW. After setting up your Email, it is much easier and faster to send a mail than go through a PR-process. On the reciving end you can respond inline to the patch, in the compfort of your email client, without having to use a browser.
My feeling is that people who don't like this, don't have a good mail setup (which is understandable given some hosts), making Email much more painful to use in general.