If macbooks were gone tomorrow, the ipad would not replace it. Very different use cases. Sure, if you took an ipad, put OSX on it, and glued it to the hinges of a macbook as the screen - then maybe it'd be very similiar. Not great performance or battery life, but similiar. But in no way am I getting work done on an ipad touchscreen with a little flimsy foldable keyboard and kickstand.
As an iOS (and Android) user and developer since about the iPad2, iPads interest me less the more iOS shifts toward being a general-purpose OS. I wouldn't buy one with macOS or equivalent on it, even if it'd been modified to work well on touch screens. At that point I'd probably get the cheapest large Android tablet I could find as a PDF reader, and just... not do the other stuff I do with iPads at all, I guess.
It'd also allow apps to dynamically load external software, which could be used as a bypass for Apple's stringent app store requirements.