Hacker News new | past | comments | ask | show | jobs | submit login

Thanks for the feedback. Please keep in mind that this project is a free time project, so when you make a generalization that my priorities are wrong and that I have lots of resources, you're a bit off base.

I've run vttest a few times; one of the biggest issues I have with it is that it isn't a unit test. It relies on a human to know what looks correct and know from what is on the screen what it was trying to do.

If you can concisely describe specific conformance issues, then I'd really appreciate it if you could file a github issue for each one. Please don't just file an issue that says "run vttest", as that isn't very actionable.




I was looking at zutty, mentioned in this thread - and the website says this:

> We have an automated regression testing setup to run VTTEST in Zutty and verify that the output is a pixel-perfect match of the pre-approved video output. You can thus expect the terminal output to be correct – be it driven by tmux, emacs (with org-mode, helm, magit, etc.) or whatever else.

Which sounds like it might be useful for you? https://github.com/tomszilagyi/zutty


Thanks for sharing!

Just before the section you quoted, it says:

> Zutty passes the subset of VTTEST screens that we care about

FWIW, wezterm passes the subset of vttest screens that I care about too :-p

More seriously though, I can't use anything from zutty as it has an incompatible license, and that approach still doesn't resolve the main issue that I have with vttest, which is that it requires a human to interpret the display and reverse engineer what's happening from the code.

esctest is a much more reasonable target for conformance testing: https://gitlab.freedesktop.org/terminal-wg/esctest/-/merge_r...


I get that this is side project that you do in your free time, but expecting reviewers to "file a github issue for each" problem they find in vttest isn't the right answer.

For example, you should maybe open a discussion on what you're seeing in vttest and compare that with OP's comment. If you don't see any problems in vttest, then say so and proceed from there.


So like... open a discussion where they can discuss specific issues? Do you realise how entitled you sound right now?


Maybe I am entitled. But if I posted a comment like OP and got the same response he did, I wouldn't be bothered to file those issues. wezfurlong's response (imo) came across as defensive and dismissive, while also redirecting any potential discussion.

As someone who maintains packages, I'd be willing to hear feedback from any source because being aware of them is better than not at all. I can't speak for how wezfurlong ranks these set of potential issues-- if they're worth even investigating for example-- but from the perspective of a person giving feedback, I would find his response as unmotivating.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: