Hacker News new | past | comments | ask | show | jobs | submit login

checked the last 10 closed pull requests

-1 closed by the author realizing it had already been done

-2 closed saying they were going to fix it differently

-1 closed saying they took some code from the commit and fixed part of it differently

-6 merged

seems quite reasonable to me (albeit this is only from the newest 10 closed pr obviously)




Your 2nd & 3rd examples I've seen a fair bit of, but I've mostly seen them closed due to the feature not lining up with Signal devs' intent.

Glad to hear this seems to be changing; 6/10 is pretty good.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: