Looking at lines 460-521 in the modified file (https://github.com/miguelxpn/php-... | Hacker News

Hacker News new | past | comments | ask | show | jobs | submit

login

osrec on March 2, 2020 | parent | context | favorite | on: I found and fixed a bug in PHP's standard library

Looking at lines 460-521 in the modified file (https://github.com/miguelxpn/php-src/blob/f4b2089b642d504be3...), is there not a benefit to `break` out of the while loop in the nested if statements?

Otherwise, it looks like it will call strstr() one extra time, even though you may have already determined that the specific header is present.

miguelxpn on March 2, 2020 [–]

Good catch! That's indeed the case. Another commit was made where that piece of code was refactored into a function and it returns 1 in case the header is present so strstr isn't being called an extra time in the current code.

[1] https://github.com/php/php-src/commit/3d9c02364db62a6d8e2794...

osrec on March 2, 2020 | [–]

Ah, much cleaner!

Consider applying for YC's W25 batch! Applications are open till Nov 12.
Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact