> there is some literature out there indicating increased income is associated with increased suicide risk.

As far as I can see, the study you cited does not support this. The quote mentions "In contrast to findings in the general population".

On the same page, a little further, it is written: "There is clear evidence from person based and ecological studies that relative poverty is associated with an increased risk of suicide." (with a couple citations)