Depends what you're complaining about.

If you don't complain when you see something wrong, e.g. a bad design choice - then you're basically a yes man (or yes woman), and you're only useful to companies who are either already perfect, or who don't want your help to do better. The first does not exist and the second would be a crap place to work.

Right, yeah. I definitely complain when there's something egregiously wrong. But as much as I like to hear myself speak, I try not to overdo it.

Capitalism will eat you alive if you don't stand up for your wages and standard of living. I used to be a naive young graduate grateful for a job with the delusion that I would commit everything to my employer and get treated fairly in return. If your employer is cash rich, you should be reaping the rewards as well, not just quietly taking a pay cheque to enrich the shareholders at disproportionate rate.

This is further compounded by the fact that, as developers, we are terrible at recognising our worth and speaking up. Doesn't help that you are conditioned into an inferiority complex constantly reinforced by a ridiculous interview process.