Regarding 1: I think the sorting approach is actually really nice in this case. ... | Hacker News

Hacker News new | past | comments | ask | show | jobs | submit

login

nunull on Nov 26, 2016 | parent | context | favorite | on: Show HN: Alter – convert text/code to an image

Regarding 1: I think the sorting approach is actually really nice in this case. Clearly it's not as efficient as a simple loop, but it's safer and more readable. Explicit looping and mutation can introduce nasty bugs which this kind of declarative approach can't.

madflame991 on Nov 26, 2016 | [–]

No need to mutate/slice/sort anything

    Math.max(...lines.map((line) => ctx.measureText(line).width))

ola on Nov 26, 2016 | [–]

I am of the same opinion, always go for correctness before performance, efficiency can be tuned later if it's even needed.

Consider applying for YC's Spring batch! Applications are open till Feb 11.
Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact