Hacker News new | past | comments | ask | show | jobs | submit | c-a's comments login

Why call it a library when it's a code generator/compiler?


Author here, you’re right. I prefer to call it a tool or an ‘approach’ but whatevs. :)


I would argue this is a new language which just happens to compile to go.


Actually it's a code generator with a library of functions it can generate. This is how the "generics" are implemented: https://github.com/clipperhouse/gen/blob/master/templates.go


Wouldn't a problem like this call for pulling the service off while it's being investigated/fixed?


There's a live image here you can give a shot: http://ftp.gnome.org/pub/gnome/misc/promo-usb/gnome-3.10.iso

I think it's based on Fedora but I haven't tested it myself yet so I'm not sure.


The request parsing code seems to be of dubious quality https://github.com/timothyej/Shortfin/blob/master/src/reques...

From a cursory glance:

1. https://github.com/timothyej/Shortfin/blob/master/src/reques...

should be (data_len - i >= 4) since it accesses data[i+3]

2. https://github.com/timothyej/Shortfin/blob/master/src/reques...

shouldn't headers[header_count]->key also be null terminated?

3. https://github.com/timothyej/Shortfin/blob/master/src/reques...

header_count can become greater than 49 which causes a heap overflow at https://github.com/timothyej/Shortfin/blob/master/src/reques... and https://github.com/timothyej/Shortfin/blob/master/src/reques...


I'll look them up, thanks for noticing!


the code in general is not that great, imho.

as well as the header count (which i came here to post), there's another suspicious hard-coded size limit in the number of servers (1000). although you could only crash the system in that case by configuring too many.

there's very little error handling. good c code returns error codes all over the damn place. this hardly has any.

i wouldn't use this.


To quote the maintainer in another bug.

--- The reason is that these settings make no sense. Why should a terminal be transparent, or have an image behind everything, but the same not apply to, say, gedit, or firefox, or evolution?


That's the problem with self-proclaimed usability experts. They see the word "consistency" and think to themselves "Oooooh, I shall make everything consistent".

This is why in Gnome, all tab bars are on top, including in the terminal. Consistency for the sake of consistency.


Terminals have only text, sometimes lots of empty space, never images. The transperency makes it look nice and people (that care to enable it) happy.


Consider applying for YC's W25 batch! Applications are open till Nov 12.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: